chore: add CI workflows, LICENSE, phpstan fixes#2
Merged
Conversation
Ship-readiness scaffolding for elm-mount.
CI (.github/workflows/):
- WP_6_6.yaml, WP_6_7.yaml, WP_6_8.yaml — PHP 8.0–8.4 matrix; runs composer all
- WP_6_9.yaml — same matrix, plus Codecov upload using the MOUNT_CODECOV secret
- All workflows mirror the Perique convention (Enqueue/Nonce style) verbatim
Files:
- LICENSE — MIT, matching the Nonce/Perique-Route template
- tests/.env_sample — committed template; tests/.env added to .gitignore
Code:
- Standard_Flags::current_user() — drop three unreachable defensive checks
flagged by phpstan -l max:
* \`! \$user\` is dead (wp_get_current_user never returns null per stubs)
* \`is_array(\$user->allcaps)\` is dead (\$allcaps is array<bool>)
* \`array_values(array_keys(...))\` is redundant — array_keys already
returns a sequential list
composer all (phpunit + phpstan level max + phpcs WordPress-Extra) is green
locally: 23 tests, 0 phpstan errors, 0 phpcs violations.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ship-readiness scaffolding for elm-mount.
CI (.github/workflows/):
Files:
Code:
composer all (phpunit + phpstan level max + phpcs WordPress-Extra) is green locally: 23 tests, 0 phpstan errors, 0 phpcs violations.